ruote tmp/log_2011-12-08.html

2011-12-07 14:55:18 utc phaeron hello, I have an issue with engine.shutdown when the engine doesn't have a worker
2011-12-07 15:09:45 utc phaeron http://pastie.org/2980802 this seems to make things work a bit better
2011-12-07 23:28:40 utc jmettraux phaeron: thanks for the patch, but when calling Dashboard#shutdown, Dashboard#worker is not called
2011-12-08 08:34:53 utc jmettraux phaeron: hello
2011-12-08 08:35:01 utc jmettraux thanks for the patch, but when calling Dashboard#shutdown, Dashboard#worker is not called
2011-12-08 08:35:50 utc phaeron jmettraux: that's not what I was seeing. for some reason it was being called and the shutdown was not finishing.
2011-12-08 08:36:00 utc phaeron with the patch it works ..
2011-12-08 08:36:24 utc phaeron Is there any way I can debug this a bit better ?
2011-12-08 08:36:35 utc jmettraux the stack trace would help, I double-checked my code and it doesn't seem to call Dashboard#worker
2011-12-08 08:37:01 utc phaeron there was no stack trace unfortunately just that one error line
2011-12-08 08:37:17 utc jmettraux which one ?
2011-12-08 08:37:31 utc phaeron one second
2011-12-08 08:39:21 utc jmettraux this https://gist.github.com/1446466 doesn't raise anything
2011-12-08 08:41:16 utc phaeron will it make a difference if we are using the deprecated Engine class and Fs storage
2011-12-08 08:42:11 utc phaeron and the fs storage was already initialized in another instance
2011-12-08 08:42:14 utc phaeron :)
2011-12-08 08:42:55 utc jmettraux Engine will be around for a long time, FsStorage should be fine
2011-12-08 08:44:41 utc jmettraux https://gist.github.com/1446473 is fine as well
2011-12-08 08:46:11 utc phaeron I am explaining the case in a gist
2011-12-08 08:47:01 utc jmettraux :-)
2011-12-08 08:50:18 utc phaeron https://gist.github.com/1446483
2011-12-08 08:51:20 utc jmettraux ah !
2011-12-08 08:52:26 utc jmettraux ok, let me fix that
2011-12-08 08:54:22 utc phaeron thanks :)
2011-12-08 08:55:08 utc jmettraux I can't reproduce the error on master...
2011-12-08 08:55:39 utc phaeron mm
2011-12-08 08:55:59 utc jmettraux what version (commit ) are you using ?
2011-12-08 08:56:45 utc phaeron this is using b66b34f1315c4bc99acec8d5db07e62160a4b896
2011-12-08 08:58:44 utc phaeron jmettraux: https://github.com/MeeGoIntegration/ruote/tree/debian
2011-12-08 08:59:11 utc jmettraux should be this version
2011-12-08 08:59:22 utc phaeron master tracks you as upstream and debian branch packages that
2011-12-08 08:59:34 utc jmettraux one thing is off: the line numbers in your stack trace are off by 1
2011-12-08 09:00:01 utc phaeron jmettraux: yeah I commented out the patched line and added another one
2011-12-08 09:00:44 utc jmettraux ok
2011-12-08 09:00:56 utc phaeron want me to try again without that line ?
2011-12-08 09:01:15 utc jmettraux anything that reproduces the bug...
2011-12-08 09:01:27 utc phaeron ruby version ?
2011-12-08 09:01:56 utc jmettraux 1.9.2p290 here
2011-12-08 09:02:41 utc jmettraux 1.8.7p249 is green too
2011-12-08 09:07:36 utc phaeron1 xorg was acting weird
2011-12-08 09:07:52 utc phaeron1 jmettraux: so trying to reproduce with that line removed ?
2011-12-08 09:10:01 utc phaeron1 jmettraux: refresh gist. the trace is cutoff but it prints the two first lines
2011-12-08 09:16:15 utc jmettraux sorry, can't reproduce the issue
2011-12-08 09:16:23 utc phaeron1 :(
2011-12-08 09:16:49 utc phaeron1 anything I can do to help ?
2011-12-08 09:17:31 utc jmettraux if you can corner the issue in one file, that'd be great
2011-12-08 09:17:32 utc phaeron1 adding a worker in the second process also helps, but then it picks up work meant for the other worker and breaks
2011-12-08 09:21:36 utc phaeron1 https://meego.gitorious.org/meego-infrastructure-tools/boss-viewer/blobs/master/boss-viewer.ru
2011-12-08 09:21:44 utc phaeron1 this is the whole of the second process
2011-12-08 09:22:08 utc phaeron1 using this file alone I can reproduce the issue
2011-12-08 09:26:36 utc jmettraux ok, I will try after the dinner, meanwhile if I could have a gist of your patched dashboard.rb
2011-12-08 09:26:40 utc jmettraux please
2011-12-08 09:27:41 utc phaeron1 the whole thing ? or just the one line patch ?
2011-12-08 09:32:03 utc phaeron1 jmettraux: https://gist.github.com/1446557
2011-12-08 10:38:06 utc jmettraux phaeron: hello, I could reproduce the issue, I will fix it ASAP
2011-12-08 12:14:49 utc jmettraux phaeron: it should be fixed with: https://github.com/jmettraux/ruote/commit/f0f621cf114a69010bedbbb69e154fec19455173
2011-12-08 12:14:51 utc jmettraux many thanks !
2011-12-08 12:16:32 utc phaeron jmettraux: wow that was fast thanks !
2011-12-08 12:16:49 utc phaeron jmettraux: and it turns out to be more complicated that I thought :)
2011-12-08 12:17:21 utc jmettraux fixed it upstreams
2011-12-08 12:18:28 utc phaeron what do you mean ?
2011-12-08 12:18:42 utc phaeron I will spin a package and give it to our tester to verify :)
2011-12-08 12:19:45 utc jmettraux your patch is in dashboard, mine is in context, upstreams in the dependency flow
2011-12-08 12:19:59 utc jmettraux ok, I will go to bed now. Thanks again !
2011-12-08 12:20:23 utc phaeron ok there is more somewhere else ?
2011-12-08 12:21:05 utc jmettraux I think it should be ok now
2011-12-08 12:21:09 utc phaeron jmettraux: ok good night o/
2011-12-08 12:21:11 utc jmettraux have a good day !
2011-12-08 21:55:02 utc jmettraux maarten: hello and welcome to #ruote
2011-12-08 22:00:59 utc phaeron jmettraux: hello
2011-12-08 22:01:08 utc jmettraux phaeron: hello
2011-12-08 22:03:35 utc phaeron jmettraux: just wanted to know what patch went upstream :)
2011-12-08 22:04:14 utc jmettraux so it went up ?
2011-12-08 22:05:26 utc phaeron you said there were two fixed in ruote and one in some other gem. I can see the ruote fixes but I don't know where to look for the other patch
2011-12-08 22:05:31 utc phaeron or did I misunderstand
2011-12-08 22:06:34 utc jmettraux sorry, I guess you misunderstood. The fix only spans 1 commit: https://github.com/jmettraux/ruote/commit/f0f621cf114a69010bedbbb69e154fec19455173
2011-12-08 22:06:48 utc jmettraux only the ruote gem is involved
2011-12-08 22:08:32 utc phaeron alright
2011-12-08 22:08:39 utc phaeron no problem , and thanks for the fast fix
2011-12-08 22:08:47 utc phaeron :)
2011-12-08 22:08:57 utc jmettraux thanks for reporting the issue !
2011-12-08 23:39:25 utc phaeron jmettraux: if you're there, I have a minor issue. This workflow definition causes ruote-flo to slow down the browser as it generates a very large image , then the image is only half way rendered. only upto the point of execution. maybe it is the flanked process causing that issue ?
2011-12-08 23:39:42 utc phaeron https://meego.gitorious.org/meego-infrastructure-tools/boss-standard-workflow/blobs/deployment-fixes-w49/processes/SRCSRV_REQUEST_CREATE.BOSS_handle_SR.pdef
2011-12-08 23:42:52 utc jmettraux phaeron: thanks, could you please fill an issue for that ? https://github.com/jmettraux/ruote-fluo/issues
2011-12-08 23:43:14 utc phaeron so you will actually accept looking at it ? :D
2011-12-08 23:43:31 utc phaeron I was expecting , that's too complex , go away :D
2011-12-08 23:43:51 utc jmettraux well, priority is low
2011-12-08 23:44:10 utc phaeron yes I agree
2011-12-08 23:44:25 utc jmettraux browser, browser version and platform might help
2011-12-08 23:46:05 utc phaeron hmm can't attach files
2011-12-08 23:47:22 utc jmettraux the link to the process definition should be sufficient
2011-12-08 23:48:20 utc phaeron yep done https://github.com/jmettraux/ruote-fluo/issues/4
2011-12-08 23:50:48 utc jmettraux thanks, I don't know how I can deal with it, probably implement something in fluo that says "hey it's too big, sorry"
2011-12-08 23:52:11 utc phaeron will splitting the process into files help ?
2011-12-08 23:53:50 utc jmettraux in some cases, yes
2011-12-08 23:54:16 utc phaeron hmm it could just be the :flank not being understood or something
2011-12-08 23:54:27 utc phaeron anyway take your time
2011-12-08 23:55:40 utc jmettraux :flank should render as any attribute
2011-12-08 23:58:53 utc phaeron any comments on how horrible the pdef is are welcome :)
2011-12-09 00:02:33 utc jmettraux sorry, too busy right now
2011-12-09 00:02:40 utc jmettraux it looks OK
2011-12-09 00:03:30 utc phaeron no problem. 2am here, good night